aboutsummaryrefslogtreecommitdiff
path: root/gitweb
diff options
context:
space:
mode:
authorJunio C Hamano <gitster@pobox.com>2008-10-20 16:36:38 -0700
committerJunio C Hamano <gitster@pobox.com>2008-10-20 23:36:31 -0700
commite249044c67d347dcffff247c72a503a9dd592294 (patch)
tree96d1ca898fb1e4a3fba56562e3606cc78db867fb /gitweb
parent80fe82e4eb365773ba6518c4539c9235ea9a8b2e (diff)
downloadgit-e249044c67d347dcffff247c72a503a9dd592294.tar.gz
git-e249044c67d347dcffff247c72a503a9dd592294.tar.xz
rebase-i-p: minimum fix to obvious issues
Jeff King noticed that this series uses non-portable ${var:0:7} syntax to splice a string, which is not even in POSIX, in the script. A quick look at around the offending part revealed a few issues, which this commit fixes: * Why filter output from "rev-list --left-right A...B" and look for the ones that begin with ">"? Wouldn't "rev-list A..B" give that? * The abbreviated SHA-1 are made with "rev-list --abbrev=7" into $TODO in an earlier invocation, and it can be more than 7 letters to avoid ambiguity. Not just that "${r:0:7} is not even in POSIX", but use of it here is actively wrong. * There is no point in catting a single file and piping it into grep. Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'gitweb')
0 files changed, 0 insertions, 0 deletions