diff options
author | Thomas Rast <trast@student.ethz.ch> | 2010-07-30 17:01:50 +0200 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2010-08-02 09:11:28 -0700 |
commit | ac2e1e632e50c682305fee902b32b1a23ce71546 (patch) | |
tree | 95b6187f93f3617291ab1c739bca741fc73ae15d /grep.c | |
parent | c97ca277a9a23780ffc322392608429f0b7e707a (diff) | |
download | git-ac2e1e632e50c682305fee902b32b1a23ce71546.tar.gz git-ac2e1e632e50c682305fee902b32b1a23ce71546.tar.xz |
Documentation/rev-parse: quoting is required with --parseopt
When calling rev-parse --parseopt, as in the (now fixed) documented
example
eval "$(echo "$OPTS_SPEC" | git rev-parse --parseopt -- "$@" || echo exit $?)"
the outermost quoting is required, as otherwise all runs of arbitrary
whitespace inside the resulting 'set -- ...' call would be collapsed
into a single space.
This was exposed as a result of our new use of cat <<\EOF since
47e9cd2 (parseopt: wrap rev-parse --parseopt usage for eval
consumption, 2010-06-12), but has always been a problem when handling
arguments containing e.g. newlines.
Point this out in the documentation, and in particular correct the
example that did not have the quotes.
Noticed-by: Joshua Jensen <jjensen@workspacewhiz.com>
Signed-off-by: Thomas Rast <trast@student.ethz.ch>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'grep.c')
0 files changed, 0 insertions, 0 deletions