diff options
author | Junio C Hamano <gitster@pobox.com> | 2016-10-27 14:58:49 -0700 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2016-10-27 14:58:49 -0700 |
commit | 00d7cc0c0b324b1b1c75b97d05423a2dc3af70cf (patch) | |
tree | da7ccf9ac82d892abf7b745187aa84ff7014f95c /hex.c | |
parent | 65aaa29f7d767acf744796ab47cb3a74dbb1c324 (diff) | |
parent | bb84735c80dbae6408b79b56f574ae672d2232d4 (diff) | |
download | git-00d7cc0c0b324b1b1c75b97d05423a2dc3af70cf.tar.gz git-00d7cc0c0b324b1b1c75b97d05423a2dc3af70cf.tar.xz |
Merge branch 'rs/ring-buffer-wraparound'
The code that we have used for the past 10+ years to cycle
4-element ring buffers turns out to be not quite portable in
theoretical world.
* rs/ring-buffer-wraparound:
hex: make wraparound of the index into ring-buffer explicit
Diffstat (limited to 'hex.c')
-rw-r--r-- | hex.c | 3 |
1 files changed, 2 insertions, 1 deletions
@@ -78,7 +78,8 @@ char *sha1_to_hex(const unsigned char *sha1) { static int bufno; static char hexbuffer[4][GIT_SHA1_HEXSZ + 1]; - return sha1_to_hex_r(hexbuffer[3 & ++bufno], sha1); + bufno = (bufno + 1) % ARRAY_SIZE(hexbuffer); + return sha1_to_hex_r(hexbuffer[bufno], sha1); } char *oid_to_hex(const struct object_id *oid) |