diff options
author | Jakub Narebski <jnareb@gmail.com> | 2011-06-22 17:28:55 +0200 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2011-06-22 11:53:37 -0700 |
commit | 1ae05be4aa448163a381e131396fd52dcf6f83eb (patch) | |
tree | 057bbb3e9f6e026edcfaa74b62d7922e4508eb54 /read-cache.c | |
parent | 882541b87d8f7bedca824228a8ad14aed69c904e (diff) | |
download | git-1ae05be4aa448163a381e131396fd52dcf6f83eb.tar.gz git-1ae05be4aa448163a381e131396fd52dcf6f83eb.tar.xz |
gitweb: Make git_search_* subroutines render whole pages
Move git_header_html() and git_footer_html() invocation from git_search()
to individual git_search_* subroutines.
While at it, reorganize search-related code a bit, moving invoking of git
commands before any output is generated.
This has the following advantages:
* gitweb now shows an error page if there was unknown search type
(evaluate_and_validate_params checks only that it looks sanely);
remember that we shouldn't call die_error after any output.
* git_search_message is now safe agains die_error in parse_commits
(though this is very unlikely).
* gitweb now can check errors while invoking git commands and show
error page (again, quite unlikely).
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'read-cache.c')
0 files changed, 0 insertions, 0 deletions