diff options
| author | Linus Torvalds <torvalds@osdl.org> | 2006-05-29 12:18:33 -0700 |
|---|---|---|
| committer | Junio C Hamano <junkio@cox.net> | 2006-05-29 19:06:59 -0700 |
| commit | 2d9c58c69d1bab601e67b036d0546e85abcee7eb (patch) | |
| tree | 18151bcd75d61a73f72522fc21c85552e49bae2f /revision.c | |
| parent | 1ccf5a345a6e7974ec0380eed735c2db97e50b4c (diff) | |
| download | git-2d9c58c69d1bab601e67b036d0546e85abcee7eb.tar.gz git-2d9c58c69d1bab601e67b036d0546e85abcee7eb.tar.xz | |
Remove "tree->entries" tree-entry list from tree parser
Instead, just use the tree buffer directly, and use the tree-walk
infrastructure to walk the buffers instead of the tree-entry list.
The tree-entry list is inefficient, and generates tons of small
allocations for no good reason. The tree-walk infrastructure is
generally no harder to use than following a linked list, and allows
us to do most tree parsing in-place.
Some programs still use the old tree-entry lists, and are a bit
painful to convert without major surgery. For them we have a helper
function that creates a temporary tree-entry list on demand.
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
Diffstat (limited to 'revision.c')
| -rw-r--r-- | revision.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/revision.c b/revision.c index 8d70a6f77..c51ea833f 100644 --- a/revision.c +++ b/revision.c @@ -63,8 +63,7 @@ void mark_tree_uninteresting(struct tree *tree) return; if (parse_tree(tree) < 0) die("bad tree %s", sha1_to_hex(obj->sha1)); - entry = tree->entries; - tree->entries = NULL; + entry = create_tree_entry_list(tree); while (entry) { struct tree_entry_list *next = entry->next; if (entry->directory) |