diff options
| author | Jeff King <peff@peff.net> | 2015-09-24 17:08:19 -0400 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2015-10-05 11:08:05 -0700 |
| commit | 34fa79a6cde56d6d428ab0d3160cb094ebad3305 (patch) | |
| tree | d75524981f407be8af783b743df86f4a0e757d0e /revision.c | |
| parent | 4c9ac3bfaad9e32a7a98178d1f01779a3698144f (diff) | |
| download | git-34fa79a6cde56d6d428ab0d3160cb094ebad3305.tar.gz git-34fa79a6cde56d6d428ab0d3160cb094ebad3305.tar.xz | |
prefer memcpy to strcpy
When we already know the length of a string (e.g., because
we just malloc'd to fit it), it's nicer to use memcpy than
strcpy, as it makes it more obvious that we are not going to
overflow the buffer (because the size we pass matches the
size in the allocation).
This also eliminates calls to strcpy, which make auditing
the code base harder.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'revision.c')
| -rw-r--r-- | revision.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/revision.c b/revision.c index af2a18ed7..22364636d 100644 --- a/revision.c +++ b/revision.c @@ -38,7 +38,7 @@ char *path_name(const struct name_path *path, const char *name) } n = xmalloc(len); m = n + len - (nlen + 1); - strcpy(m, name); + memcpy(m, name, nlen + 1); for (p = path; p; p = p->up) { if (p->elem_len) { m -= p->elem_len + 1; |