diff options
| author | Jeff King <peff@peff.net> | 2009-05-18 13:58:11 -0400 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2009-05-20 00:06:19 -0700 |
| commit | e64c1b0053f2dc4fc5b434a9806b90318bac9592 (patch) | |
| tree | a531a2cb6275af5df03dc003091eeceaf5d8891d /sha1_file.c | |
| parent | 5acb3e5012966cc11e54f50e0592b3639bade02c (diff) | |
| download | git-e64c1b0053f2dc4fc5b434a9806b90318bac9592.tar.gz git-e64c1b0053f2dc4fc5b434a9806b90318bac9592.tar.xz | |
for-each-ref: fix segfault in copy_email
You can trigger a segfault in git.git by doing:
git for-each-ref --format='%(taggeremail)' refs/tags/v0.99
The v0.99 tag is special in that it contains no "tagger"
header.
The bug is obvious in copy_email, which carefully checks to
make sure the result of a strchr is non-NULL, but only after
already having used it to perform other work. The fix is to
move the check up.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'sha1_file.c')
0 files changed, 0 insertions, 0 deletions