aboutsummaryrefslogtreecommitdiff
path: root/t/lib-credential.sh
diff options
context:
space:
mode:
authorElia Pinto <gitter.spiros@gmail.com>2014-04-23 06:44:03 -0700
committerJunio C Hamano <gitster@pobox.com>2014-04-23 15:17:02 -0700
commit5a4352024ae71613186730e3a3ab670f43904ad6 (patch)
tree172825f4bb08c85b15839543ce2cd67074111001 /t/lib-credential.sh
parent9e5878fbede57c0499133adf73844261849cd7b2 (diff)
downloadgit-5a4352024ae71613186730e3a3ab670f43904ad6.tar.gz
git-5a4352024ae71613186730e3a3ab670f43904ad6.tar.xz
lib-credential.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia Pinto <gitter.spiros@gmail.com> Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/lib-credential.sh')
-rwxr-xr-xt/lib-credential.sh2
1 files changed, 1 insertions, 1 deletions
diff --git a/t/lib-credential.sh b/t/lib-credential.sh
index 957ae936e..9e7d7962b 100755
--- a/t/lib-credential.sh
+++ b/t/lib-credential.sh
@@ -281,7 +281,7 @@ helper_test_timeout() {
cat >askpass <<\EOF
#!/bin/sh
echo >&2 askpass: $*
-what=`echo $1 | cut -d" " -f1 | tr A-Z a-z | tr -cd a-z`
+what=$(echo $1 | cut -d" " -f1 | tr A-Z a-z | tr -cd a-z)
echo "askpass-$what"
EOF
chmod +x askpass