diff options
| author | Vasco Almeida <vascomalmeida@sapo.pt> | 2016-06-17 20:21:07 +0000 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2016-06-17 15:45:48 -0700 |
| commit | 1edbaac3bbe1a55cf3450ae7a350b50826d5d283 (patch) | |
| tree | 8d96ba6ba90615e0c690b2e4cd4d9373ec66ee6f /t/t1307-config-blob.sh | |
| parent | ab33a76ec5313b00d630a14d2a843cdb942ed2be (diff) | |
| download | git-1edbaac3bbe1a55cf3450ae7a350b50826d5d283.tar.gz git-1edbaac3bbe1a55cf3450ae7a350b50826d5d283.tar.xz | |
tests: use test_i18n* functions to suppress false positives
The test functions test_i18ncmp and test_i18ngrep pretend success if run
under GETTEXT_POISON. By using those functions to test output which is
correctly marked as translatable, enables one to detect if the strings
newly marked for translation are from plumbing output. If they are
indeed from plumbing, the test would fail, and the string should be
unmarked, since it is not seen by users.
Thus, it is productive to not have false positives when running the test
under GETTEXT_POISON. This commit replaces normal test functions by
their i18n aware variants in use-cases know to be correctly marked for
translation, suppressing false positives.
Signed-off-by: Vasco Almeida <vascomalmeida@sapo.pt>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t1307-config-blob.sh')
| -rwxr-xr-x | t/t1307-config-blob.sh | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/t/t1307-config-blob.sh b/t/t1307-config-blob.sh index 3c6791e6b..eed31ffa3 100755 --- a/t/t1307-config-blob.sh +++ b/t/t1307-config-blob.sh @@ -61,10 +61,7 @@ test_expect_success 'parse errors in blobs are properly attributed' ' git commit -m broken && test_must_fail git config --blob=HEAD:config some.value 2>err && - - # just grep for our token as the exact error message is likely to - # change or be internationalized - grep "HEAD:config" err + test_i18ngrep "HEAD:config" err ' test_expect_success 'can parse blob ending with CR' ' |