aboutsummaryrefslogtreecommitdiff
path: root/t/t4031-diff-rewrite-binary.sh
diff options
context:
space:
mode:
authorJeff King <peff@peff.net>2009-12-30 06:01:09 -0500
committerJunio C Hamano <gitster@pobox.com>2010-01-05 23:41:51 -0800
commit41a457e4f814a0e514548b3178e7692129f0fcfe (patch)
tree3b1a66dac76d179328110fe33c92f728ce7410e2 /t/t4031-diff-rewrite-binary.sh
parentbac8037081735a49bccdc3b3b1457129f9bcc451 (diff)
downloadgit-41a457e4f814a0e514548b3178e7692129f0fcfe.tar.gz
git-41a457e4f814a0e514548b3178e7692129f0fcfe.tar.xz
textconv: use shell to run helper
Currently textconv helpers are run directly. Running through the shell is useful because the user can provide a program with command line arguments, like "antiword -f". It also makes textconv more consistent with other parts of git, most of which run their helpers using the shell. The downside is that textconv helpers with shell metacharacters (like space) in the filename will be broken. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t4031-diff-rewrite-binary.sh')
-rwxr-xr-xt/t4031-diff-rewrite-binary.sh2
1 files changed, 1 insertions, 1 deletions
diff --git a/t/t4031-diff-rewrite-binary.sh b/t/t4031-diff-rewrite-binary.sh
index a894c6062..27fb31b40 100755
--- a/t/t4031-diff-rewrite-binary.sh
+++ b/t/t4031-diff-rewrite-binary.sh
@@ -54,7 +54,7 @@ chmod +x dump
test_expect_success 'setup textconv' '
echo file diff=foo >.gitattributes &&
- git config diff.foo.textconv "$PWD"/dump
+ git config diff.foo.textconv "\"$PWD\""/dump
'
test_expect_success 'rewrite diff respects textconv' '