diff options
author | Junio C Hamano <gitster@pobox.com> | 2008-05-23 22:28:56 -0700 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2008-05-24 00:01:56 -0700 |
commit | 3af828634fa5bdbca1b2061a81df8b3fa73b0d34 (patch) | |
tree | f4d4a50e8c1686b3ecd796a09f98cc6ca13bc907 /t/t5305-include-tag.sh | |
parent | 998b912927281a871e8d379e2b3a4385c775c4fe (diff) | |
download | git-3af828634fa5bdbca1b2061a81df8b3fa73b0d34.tar.gz git-3af828634fa5bdbca1b2061a81df8b3fa73b0d34.tar.xz |
tests: do not use implicit "git diff --no-index"
As a general principle, we should not use "git diff" to validate the
results of what git command that is being tested has done. We would not
know if we are testing the command in question, or locating a bug in the
cute hack of "git diff --no-index".
Rather use test_cmp for that purpose.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t5305-include-tag.sh')
-rwxr-xr-x | t/t5305-include-tag.sh | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/t/t5305-include-tag.sh b/t/t5305-include-tag.sh index 0db27547a..fb471a08c 100755 --- a/t/t5305-include-tag.sh +++ b/t/t5305-include-tag.sh @@ -50,7 +50,7 @@ test_expect_success 'check unpacked result (have commit, no tag)' ' test_must_fail git cat-file -e $tag && git rev-list --objects $commit ) >list.actual && - git diff list.expect list.actual + test_cmp list.expect list.actual ' rm -rf clone.git @@ -78,7 +78,7 @@ test_expect_success 'check unpacked result (have commit, have tag)' ' export GIT_DIR && git rev-list --objects $tag ) >list.actual && - git diff list.expect list.actual + test_cmp list.expect list.actual ' test_done |