diff options
| author | Torsten Bögershausen <tboegi@web.de> | 2013-11-28 20:49:54 +0100 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2013-12-09 14:54:47 -0800 |
| commit | 83b058752707a6ba4af51ebc98c47913bc7d2d25 (patch) | |
| tree | 2c8026c588066e1a1f1b5ce8dae4c18f73c70a29 /t/t5601-clone.sh | |
| parent | 6a59974869c0a6e9399101bc02223b4c00a8aff2 (diff) | |
| download | git-83b058752707a6ba4af51ebc98c47913bc7d2d25.tar.gz git-83b058752707a6ba4af51ebc98c47913bc7d2d25.tar.xz | |
git_connect(): refactor the port handling for ssh
Use get_host_and_port() even for ssh.
Remove the variable port git_connect(), and simplify parse_connect_url()
Use only one return point in git_connect(), doing the free() and return conn.
t5601 had 2 corner test cases which now pass.
Signed-off-by: Torsten Bögershausen <tboegi@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t5601-clone.sh')
| -rwxr-xr-x | t/t5601-clone.sh | 10 |
1 files changed, 1 insertions, 9 deletions
diff --git a/t/t5601-clone.sh b/t/t5601-clone.sh index 4db0c0b01..53a1de9ef 100755 --- a/t/t5601-clone.sh +++ b/t/t5601-clone.sh @@ -364,15 +364,7 @@ do done # Corner cases -# failing -for url in [foo]bar/baz:qux [foo/bar]:baz -do - test_expect_failure "clone $url is not ssh" ' - test_clone_url $url none - ' -done - -for url in foo/bar:baz +for url in foo/bar:baz [foo]bar/baz:qux [foo/bar]:baz do test_expect_success "clone $url is not ssh" ' test_clone_url $url none |