diff options
| author | Adeodato Simó <dato@net.com.org.es> | 2009-01-09 18:30:05 +0100 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2009-01-10 17:45:02 -0800 |
| commit | 7eb5bbdb645e04d746bc0edea102744f50a5e529 (patch) | |
| tree | d37d6fa74195b5ed5237ca9166f400688090ca01 /t/t7500-commit.sh | |
| parent | df3987717f1546719a1bf1828fb3714cd5ca9faa (diff) | |
| download | git-7eb5bbdb645e04d746bc0edea102744f50a5e529.tar.gz git-7eb5bbdb645e04d746bc0edea102744f50a5e529.tar.xz | |
t7501-commit.sh: explicitly check that -F prevents invoking the editor
The "--signoff" test case in t7500-commit.sh was setting VISUAL while
using -F -, which indeed tested that the editor is not spawned with -F.
However, having it there was confusing, since there was no obvious reason
to the casual reader for it to be there.
This commits removes the setting of VISUAL from the --signoff test, and
adds in t7501-commit.sh a dedicated test case, where the rest of tests for
-F are.
Signed-off-by: Adeodato Simó <dato@net.com.org.es>
Okay-then-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t7500-commit.sh')
| -rwxr-xr-x | t/t7500-commit.sh | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/t/t7500-commit.sh b/t/t7500-commit.sh index 6e18a9631..5998baf27 100755 --- a/t/t7500-commit.sh +++ b/t/t7500-commit.sh @@ -149,10 +149,7 @@ EOF test_expect_success '--signoff' ' echo "yet another content *narf*" >> foo && - echo "zort" | ( - test_set_editor "$TEST_DIRECTORY"/t7500/add-content && - git commit -s -F - foo - ) && + echo "zort" | git commit -s -F - foo && git cat-file commit HEAD | sed "1,/^$/d" > output && test_cmp expect output ' |