aboutsummaryrefslogtreecommitdiff
path: root/t/t9808-git-p4-chdir.sh
diff options
context:
space:
mode:
authorPete Wyckoff <pw@padd.com>2013-03-07 18:19:15 -0500
committerJunio C Hamano <gitster@pobox.com>2013-03-07 16:00:49 -0800
commit9e7b8efb9d8fde168fee2c12c57903bbb93fd115 (patch)
treeaa24348a17c5d97dbb8266a36fead11e7edaa3c3 /t/t9808-git-p4-chdir.sh
parentaadb70a5594222cac215f9590017f05d5d0f31b2 (diff)
downloadgit-9e7b8efb9d8fde168fee2c12c57903bbb93fd115.tar.gz
git-9e7b8efb9d8fde168fee2c12c57903bbb93fd115.tar.xz
git p4 test: make sure P4CONFIG relative path works
This adds a test for the fix in bf1d68f (git-p4: use absolute directory for PWD env var, 2011-12-09). It is necessary to set PWD to an absolute path so that p4 can find files referenced by non-absolute paths, like the value of the P4CONFIG environment variable. P4 does not open files directly; it builds a path by prepending the contents of the PWD environment variable. Signed-off-by: Pete Wyckoff <pw@padd.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/t9808-git-p4-chdir.sh')
-rwxr-xr-xt/t9808-git-p4-chdir.sh14
1 files changed, 14 insertions, 0 deletions
diff --git a/t/t9808-git-p4-chdir.sh b/t/t9808-git-p4-chdir.sh
index dc92e60cd..55c5e36a2 100755
--- a/t/t9808-git-p4-chdir.sh
+++ b/t/t9808-git-p4-chdir.sh
@@ -42,6 +42,20 @@ test_expect_success 'P4CONFIG and relative dir clone' '
)
'
+# Common setup using .p4config to set P4CLIENT and P4PORT breaks
+# if clone destination is relative. Make sure that chdir() expands
+# the relative path in --dest to absolute.
+test_expect_success 'p4 client root would be relative due to clone --dest' '
+ test_when_finished cleanup_git &&
+ (
+ echo P4PORT=$P4PORT >git/.p4config &&
+ P4CONFIG=.p4config &&
+ export P4CONFIG &&
+ unset P4PORT &&
+ git p4 clone --dest="git" //depot
+ )
+'
+
test_expect_success 'kill p4d' '
kill_p4d
'