diff options
| author | Jeff King <peff@peff.net> | 2013-12-28 04:31:49 -0500 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2014-01-02 14:43:11 -0800 |
| commit | a63c12c9be28bf455816b1ece4a52b463ecf6241 (patch) | |
| tree | 6ffbbe6e57a3029ff75bf1745d4f651fca5869ae /t/test-lib.sh | |
| parent | 68830470712b370d5ea231f76babd60a8859c105 (diff) | |
| download | git-a63c12c9be28bf455816b1ece4a52b463ecf6241.tar.gz git-a63c12c9be28bf455816b1ece4a52b463ecf6241.tar.xz | |
t0000: simplify HARNESS_ACTIVE hack
Commit 517cd55 set HARNESS_ACTIVE unconditionally in
sub-tests, because that value affects the output of
"--verbose". t0000 needs stable output from its sub-tests,
and we may or may not be running under a TAP harness.
That commit made the decision to always set the variable,
since it has another useful side effect, which is
suppressing writes to t/test-results by the sub-tests (which
would just pollute the real results).
Since the last commit, though, the sub-tests have their own
test-results directories, so this is no longer an issue. We
can now update a few comments that are no longer accurate
nor necessary.
We can also revisit the choice of HARNESS_ACTIVE. Since we
must choose one value for stability, it's probably saner to
have it off. This means that future patches could test
things like the test-results writing, or the "--quiet"
option, which is currently ignored when run under a harness.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't/test-lib.sh')
| -rw-r--r-- | t/test-lib.sh | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/t/test-lib.sh b/t/test-lib.sh index b25249ec4..f54a77c29 100644 --- a/t/test-lib.sh +++ b/t/test-lib.sh @@ -477,8 +477,6 @@ test_at_end_hook_ () { test_done () { GIT_EXIT_OK=t - # Note: t0000 relies on $HARNESS_ACTIVE disabling the .counts - # output file if test -z "$HARNESS_ACTIVE" then test_results_dir="$TEST_OUTPUT_DIRECTORY/test-results" |