diff options
author | Johannes Schindelin <Johannes.Schindelin@gmx.de> | 2007-11-11 17:35:58 +0000 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2007-11-22 17:05:03 -0800 |
commit | 13208572fbe8838fd8835548d7502202d1f7b21d (patch) | |
tree | 33292fe1e4b5144f3399ab630e862f8f254b2249 /t | |
parent | 367c98866c340bc9cf5cfa88c3b69f027165fc44 (diff) | |
download | git-13208572fbe8838fd8835548d7502202d1f7b21d.tar.gz git-13208572fbe8838fd8835548d7502202d1f7b21d.tar.xz |
builtin-commit: fix --signoff
The Signed-off-by: line contained a spurious timestamp. The reason was
a call to git_committer_info(1), which automatically added the
timestamp.
Instead, fmt_ident() was taught to interpret an empty string for the
date (as opposed to NULL, which still triggers the default behavior)
as "do not bother with the timestamp", and builtin-commit.c uses it.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't')
-rwxr-xr-x | t/t7500-commit.sh | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/t/t7500-commit.sh b/t/t7500-commit.sh index cf389b81d..49c1922dd 100755 --- a/t/t7500-commit.sh +++ b/t/t7500-commit.sh @@ -122,7 +122,19 @@ test_expect_success 'using alternate GIT_INDEX_FILE (2)' ' ) && cmp .git/index saved-index >/dev/null +' +cat > expect << EOF +zort +Signed-off-by: C O Mitter <committer@example.com> +EOF + +test_expect_success '--signoff' ' + echo "yet another content *narf*" >> foo && + echo "zort" | + GIT_EDITOR=../t7500/add-content git commit -s -F - foo && + git cat-file commit HEAD | sed "1,/^$/d" > output && + diff expect output ' test_done |