diff options
| author | Junio C Hamano <gitster@pobox.com> | 2013-02-04 10:25:18 -0800 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2013-02-04 10:25:18 -0800 |
| commit | d5365b43274779246665416caf1a51af5a29f776 (patch) | |
| tree | 4964cb7640ffec8458d3a56815d0d4c21369f1f6 /t | |
| parent | 27d46a70724ef5e087863c3db35eb7ca9c084c2c (diff) | |
| parent | be5c9fb9049ed470e7005f159bb923a5f4de1309 (diff) | |
| download | git-d5365b43274779246665416caf1a51af5a29f776.tar.gz git-d5365b43274779246665416caf1a51af5a29f776.tar.xz | |
Merge branch 'jk/read-commit-buffer-data-after-free'
Clarify the ownership rule for commit->buffer field, which some
callers incorrectly accessed without making sure it is populated.
* jk/read-commit-buffer-data-after-free:
logmsg_reencode: lazily load missing commit buffers
logmsg_reencode: never return NULL
commit: drop useless xstrdup of commit message
Diffstat (limited to 't')
| -rwxr-xr-x | t/t4042-diff-textconv-caching.sh | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/t/t4042-diff-textconv-caching.sh b/t/t4042-diff-textconv-caching.sh index 91f8198f0..04a44d5c6 100755 --- a/t/t4042-diff-textconv-caching.sh +++ b/t/t4042-diff-textconv-caching.sh @@ -106,4 +106,12 @@ test_expect_success 'switching diff driver produces correct results' ' test_cmp expect actual ' +# The point here is to test that we can log the notes cache and still use it to +# produce a diff later (older versions of git would segfault on this). It's +# much more likely to come up in the real world with "log --all -p", but using +# --no-walk lets us reliably reproduce the order of traversal. +test_expect_success 'log notes cache and still use cache for -p' ' + git log --no-walk -p refs/notes/textconv/magic HEAD +' + test_done |