diff options
| author | Michael Haggerty <mhagger@alum.mit.edu> | 2011-08-04 06:36:14 +0200 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2011-08-04 15:53:15 -0700 |
| commit | c0b13b21b8daa4bfb222e9c4d335c8b340c511a0 (patch) | |
| tree | 92db170d41d4b9ba30daf5ef623196dacf7bd189 /t | |
| parent | d42453ab1a482df0fdb428c20de1189a21a2bee1 (diff) | |
| download | git-c0b13b21b8daa4bfb222e9c4d335c8b340c511a0.tar.gz git-c0b13b21b8daa4bfb222e9c4d335c8b340c511a0.tar.xz | |
Disallow the empty string as an attribute name
Previously, it was possible to have a line like "file.txt =foo" in a
.gitattribute file, after which an invocation like "git check-attr ''
-- file.txt" would succeed. This patch disallows both constructs.
Please note that any existing .gitattributes file that tries to set an
empty attribute will now trigger the error message "error: : not a
valid attribute name" whereas previously the nonsense was allowed
through.
Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 't')
| -rwxr-xr-x | t/t0003-attributes.sh | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/t/t0003-attributes.sh b/t/t0003-attributes.sh index ebbc7554a..8c76b79bb 100755 --- a/t/t0003-attributes.sh +++ b/t/t0003-attributes.sh @@ -42,6 +42,12 @@ test_expect_success 'setup' ' ' +test_expect_success 'command line checks' ' + + test_must_fail git check-attr "" -- f + +' + test_expect_success 'attribute test' ' attr_check f f && |