aboutsummaryrefslogtreecommitdiff
path: root/test-sha1.sh
diff options
context:
space:
mode:
authorElia Pinto <gitter.spiros@gmail.com>2015-12-22 15:10:31 +0100
committerJunio C Hamano <gitster@pobox.com>2015-12-27 15:33:13 -0800
commit21c6f9875a01484875ff17ec472568e1aadceb8f (patch)
tree6f2d5278e8519acf9ba34bea2e3fd6122fe988e6 /test-sha1.sh
parente429dfd5e49e8eb5471ae82cfdd9a86bc1f587f4 (diff)
downloadgit-21c6f9875a01484875ff17ec472568e1aadceb8f.tar.gz
git-21c6f9875a01484875ff17ec472568e1aadceb8f.tar.xz
test-sha1.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}" done and then carefully proof-read. Signed-off-by: Elia Pinto <gitter.spiros@gmail.com> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'test-sha1.sh')
-rwxr-xr-xtest-sha1.sh8
1 files changed, 4 insertions, 4 deletions
diff --git a/test-sha1.sh b/test-sha1.sh
index 0f0bc5d02..cef4bcc86 100755
--- a/test-sha1.sh
+++ b/test-sha1.sh
@@ -6,13 +6,13 @@ dd if=/dev/zero bs=1048576 count=100 2>/dev/null |
while read expect cnt pfx
do
case "$expect" in '#'*) continue ;; esac
- actual=`
+ actual=$(
{
test -z "$pfx" || echo "$pfx"
dd if=/dev/zero bs=1048576 count=$cnt 2>/dev/null |
perl -pe 'y/\000/g/'
} | ./test-sha1 $cnt
- `
+ )
if test "$expect" = "$actual"
then
echo "OK: $expect $cnt $pfx"
@@ -51,14 +51,14 @@ exit
while read cnt pfx
do
- actual=`
+ actual=$(
{
test -z "$pfx" || echo "$pfx"
dd if=/dev/zero bs=1048576 count=$cnt 2>/dev/null |
perl -pe 'y/\000/g/'
} | sha1sum |
sed -e 's/ .*//'
- `
+ )
echo "$actual $cnt $pfx"
done <<EOF
0