diff options
| author | Jeff King <peff@peff.net> | 2013-07-09 20:18:40 -0400 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2013-07-09 22:23:04 -0700 |
| commit | 4621085b7eb2f4cffe16d508988ff9b4a874b4ef (patch) | |
| tree | e00d04f064c23918768aafaa93656a07949a95db /transport-helper.c | |
| parent | edca4152560522a431a51fc0a06147fc680b5b18 (diff) | |
| download | git-4621085b7eb2f4cffe16d508988ff9b4a874b4ef.tar.gz git-4621085b7eb2f4cffe16d508988ff9b4a874b4ef.tar.xz | |
add missing "format" function attributes
For most of our functions that take printf-like formats, we
use gcc's __attribute__((format)) to get compiler warnings
when the functions are misused. Let's give a few more
functions the same protection.
In most cases, the annotations do not uncover any actual
bugs; the only code change needed is that we passed a size_t
to transfer_debug, which expected an int. Since we expect
the passed-in value to be a relatively small buffer size
(and cast a similar value to int directly below), we can
just cast away the problem.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'transport-helper.c')
| -rw-r--r-- | transport-helper.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/transport-helper.c b/transport-helper.c index 522d79178..111336aaf 100644 --- a/transport-helper.c +++ b/transport-helper.c @@ -955,6 +955,7 @@ int transport_helper_init(struct transport *transport, const char *name) #define PBUFFERSIZE 8192 /* Print bidirectional transfer loop debug message. */ +__attribute__((format (printf, 1, 2))) static void transfer_debug(const char *fmt, ...) { va_list args; @@ -1040,7 +1041,7 @@ static int udt_do_read(struct unidirectional_transfer *t) return -1; } else if (bytes == 0) { transfer_debug("%s EOF (with %i bytes in buffer)", - t->src_name, t->bufuse); + t->src_name, (int)t->bufuse); t->state = SSTATE_FLUSHING; } else if (bytes > 0) { t->bufuse += bytes; |