diff options
| author | Junio C Hamano <gitster@pobox.com> | 2015-08-24 13:03:07 -0700 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2015-08-24 13:09:02 -0700 |
| commit | 12d6ce1dba504dfc5279b8d24da3edb4865c2820 (patch) | |
| tree | b986a6e22bf290aa4f74d566169a6d54db6e4f3f /transport.c | |
| parent | 57c867efe4e005e40cfdee8a64550d7a95bbb9a0 (diff) | |
| download | git-12d6ce1dba504dfc5279b8d24da3edb4865c2820.tar.gz git-12d6ce1dba504dfc5279b8d24da3edb4865c2820.tar.xz | |
write_file(): drop "fatal" parameter
All callers except three passed 1 for the "fatal" parameter to ask
this function to die upon error, but to a casual reader of the code,
it was not all obvious what that 1 meant. Instead, split the
function into two based on a common write_file_v() that takes the
flag, introduce write_file_gently() as a new way to attempt creating
a file without dying on error, and make three callers to call it.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'transport.c')
| -rw-r--r-- | transport.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/transport.c b/transport.c index 40692f8ae..025439435 100644 --- a/transport.c +++ b/transport.c @@ -291,7 +291,7 @@ static int write_one_ref(const char *name, const struct object_id *oid, strbuf_addstr(buf, name); if (safe_create_leading_directories(buf->buf) || - write_file(buf->buf, 0, "%s\n", oid_to_hex(oid))) + write_file_gently(buf->buf, "%s\n", oid_to_hex(oid))) return error("problems writing temporary file %s: %s", buf->buf, strerror(errno)); strbuf_setlen(buf, len); |