aboutsummaryrefslogtreecommitdiff
path: root/transport.c
diff options
context:
space:
mode:
authorJunio C Hamano <gitster@pobox.com>2009-08-10 22:14:57 -0700
committerJunio C Hamano <gitster@pobox.com>2009-08-10 22:14:57 -0700
commit08ac69685a5b6bea45df1fd62ea1d9b7c0258d0b (patch)
tree3f3ccdcda78c82ed450666d22a0b463cf3eac6b3 /transport.c
parent0c4f21e452dca5a705c36ca7e363c1a3b3c2a5b8 (diff)
parent0b91322311b649a4b5f9581fec2dca9e1c2da716 (diff)
downloadgit-08ac69685a5b6bea45df1fd62ea1d9b7c0258d0b.tar.gz
git-08ac69685a5b6bea45df1fd62ea1d9b7c0258d0b.tar.xz
Merge branch 'js/run-command-updates'
* js/run-command-updates: api-run-command.txt: describe error behavior of run_command functions run-command.c: squelch a "use before assignment" warning receive-pack: remove unnecessary run_status report run_command: report failure to execute the program, but optionally don't run_command: encode deadly signal number in the return value run_command: report system call errors instead of returning error codes run_command: return exit code as positive value MinGW: simplify waitpid() emulation macros
Diffstat (limited to 'transport.c')
-rw-r--r--transport.c16
1 files changed, 1 insertions, 15 deletions
diff --git a/transport.c b/transport.c
index de0d5874a..8a42e76b3 100644
--- a/transport.c
+++ b/transport.c
@@ -396,7 +396,6 @@ static int curl_transport_push(struct transport *transport, int refspec_nr, cons
{
const char **argv;
int argc;
- int err;
if (flags & TRANSPORT_PUSH_MIRROR)
return error("http transport does not support mirror mode");
@@ -416,20 +415,7 @@ static int curl_transport_push(struct transport *transport, int refspec_nr, cons
while (refspec_nr--)
argv[argc++] = *refspec++;
argv[argc] = NULL;
- err = run_command_v_opt(argv, RUN_GIT_CMD);
- switch (err) {
- case -ERR_RUN_COMMAND_FORK:
- error("unable to fork for %s", argv[0]);
- case -ERR_RUN_COMMAND_EXEC:
- error("unable to exec %s", argv[0]);
- break;
- case -ERR_RUN_COMMAND_WAITPID:
- case -ERR_RUN_COMMAND_WAITPID_WRONG_PID:
- case -ERR_RUN_COMMAND_WAITPID_SIGNAL:
- case -ERR_RUN_COMMAND_WAITPID_NOEXIT:
- error("%s died with strange error", argv[0]);
- }
- return !!err;
+ return !!run_command_v_opt(argv, RUN_GIT_CMD);
}
static struct ref *get_refs_via_curl(struct transport *transport, int for_push)