aboutsummaryrefslogtreecommitdiff
path: root/unpack-objects.c
diff options
context:
space:
mode:
authorNicolas Pitre <nico@cam.org>2006-02-09 17:50:04 -0500
committerJunio C Hamano <junkio@cox.net>2006-02-09 21:06:38 -0800
commitd60fc1c8649f80c006b9f493c542461e81608d4b (patch)
treed481762cf3c8954e9bc635c61127b77342ae79d0 /unpack-objects.c
parent67d42212ff104aaafa97b943cb369b8444f61581 (diff)
downloadgit-d60fc1c8649f80c006b9f493c542461e81608d4b.tar.gz
git-d60fc1c8649f80c006b9f493c542461e81608d4b.tar.xz
remove delta-against-self bit
After experimenting with code to add the ability to encode a delta against part of the deltified file, it turns out that resulting packs are _bigger_ than when this ability is not used. The raw delta output might be smaller, but it doesn't compress as well using gzip with a negative net saving on average. Said bit would in fact be more useful to allow for encoding the copying of chunks larger than 64KB providing more savings with large files. This will correspond to packs version 3. While the current code still produces packs version 2, it is made future proof so pack versions 2 and 3 are accepted. Any pack version 2 are compatible with version 3 since the redefined bit was never used before. When enough time has passed, code to use that bit to produce version 3 packs could be added. Signed-off-by: Nicolas Pitre <nico@cam.org> Signed-off-by: Junio C Hamano <junkio@cox.net>
Diffstat (limited to 'unpack-objects.c')
-rw-r--r--unpack-objects.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/unpack-objects.c b/unpack-objects.c
index 4b5b5cb3e..815a1b382 100644
--- a/unpack-objects.c
+++ b/unpack-objects.c
@@ -246,13 +246,12 @@ static void unpack_all(void)
{
int i;
struct pack_header *hdr = fill(sizeof(struct pack_header));
- unsigned version = ntohl(hdr->hdr_version);
unsigned nr_objects = ntohl(hdr->hdr_entries);
if (ntohl(hdr->hdr_signature) != PACK_SIGNATURE)
die("bad pack file");
- if (version != PACK_VERSION)
- die("unable to handle pack file version %d", version);
+ if (!pack_version_ok(hdr->hdr_version))
+ die("unknown pack file version %d", ntohl(hdr->hdr_version));
fprintf(stderr, "Unpacking %d objects\n", nr_objects);
use(sizeof(struct pack_header));