diff options
| author | Jeff King <peff@peff.net> | 2008-10-23 04:30:58 +0000 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2008-11-01 23:46:34 -0700 |
| commit | 13494ed14c3539b3e36ff47d1d8b65f5a9a3043b (patch) | |
| tree | c02062778a40cb0cb3c63d5675e8e94dcc643231 /unpack-trees.c | |
| parent | faf1dc7223be9ffddf775916913bb8e22762cdfb (diff) | |
| download | git-13494ed14c3539b3e36ff47d1d8b65f5a9a3043b.tar.gz git-13494ed14c3539b3e36ff47d1d8b65f5a9a3043b.tar.xz | |
correct cache_entry allocation
Most cache_entry structs are allocated by using the
cache_entry_size macro, which rounds the size of the struct
up to the nearest multiple of 8 bytes (presumably to avoid
memory fragmentation).
There is one exception: the special "conflict entry" is
allocated with an empty name, and so is explicitly given
just one extra byte to hold the NUL.
However, later code doesn't realize that this particular
struct has been allocated differently, and happily tries
reading and copying it based on the ce_size macro, which
assumes the 8-byte alignment.
This can lead to reading uninitalized data, though since
that data is simply padding, there shouldn't be any problem
as a result. Still, it makes sense to hold the padding
assumption so as not to surprise later maintainers.
This fixes valgrind errors in t1005, t3030, t4002, and
t4114.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'unpack-trees.c')
| -rw-r--r-- | unpack-trees.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/unpack-trees.c b/unpack-trees.c index e59d144d2..e5749ef63 100644 --- a/unpack-trees.c +++ b/unpack-trees.c @@ -382,7 +382,7 @@ int unpack_trees(unsigned len, struct tree_desc *t, struct unpack_trees_options o->merge_size = len; if (!dfc) - dfc = xcalloc(1, sizeof(struct cache_entry) + 1); + dfc = xcalloc(1, cache_entry_size(0)); o->df_conflict_entry = dfc; if (len) { |