aboutsummaryrefslogtreecommitdiff
path: root/wrapper.c
diff options
context:
space:
mode:
authorJunio C Hamano <gitster@pobox.com>2013-07-22 11:23:12 -0700
committerJunio C Hamano <gitster@pobox.com>2013-07-22 11:23:13 -0700
commit1d1934caf1c927cb12cd76aa6ced9eab51a3d435 (patch)
tree7221825fc2700eb3b743335c2dc2b55e22b4d0c8 /wrapper.c
parent6a5b9ce5e12f039b126b1c97be7ba1b63ace5149 (diff)
parenta77f106c7837faf6a712ea3ac720f5c4fa2feb07 (diff)
downloadgit-1d1934caf1c927cb12cd76aa6ced9eab51a3d435.tar.gz
git-1d1934caf1c927cb12cd76aa6ced9eab51a3d435.tar.xz
Merge branch 'tr/fd-gotcha-fixes'
Two places we did not check return value (expected to be a file descriptor) correctly. * tr/fd-gotcha-fixes: run-command: dup_devnull(): guard against syscalls failing git_mkstemps: correctly test return value of open()
Diffstat (limited to 'wrapper.c')
-rw-r--r--wrapper.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/wrapper.c b/wrapper.c
index dd7ecbb11..6a015de5f 100644
--- a/wrapper.c
+++ b/wrapper.c
@@ -322,7 +322,7 @@ int git_mkstemps_mode(char *pattern, int suffix_len, int mode)
template[5] = letters[v % num_letters]; v /= num_letters;
fd = open(pattern, O_CREAT | O_EXCL | O_RDWR, mode);
- if (fd > 0)
+ if (fd >= 0)
return fd;
/*
* Fatal error (EPERM, ENOSPC etc).