aboutsummaryrefslogtreecommitdiff
path: root/t/t9820-git-p4-editor-handling.sh
Commit message (Collapse)AuthorAge
* git-p4: fix handling of multi-word P4EDITORLuke Diamand2015-05-24
| | | | | | | | | | | | | | This teaches git-p4 to pass the P4EDITOR variable to the shell for expansion, so that any command-line arguments are correctly handled. Without this, git-p4 can only launch the editor if P4EDITOR is solely the path to the binary, without any arguments. This also adjusts t9805, which relied on the previous behaviour. Suggested-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Luke Diamand <luke@diamand.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>
* git-p4: add failing test for P4EDITOR handlingLuke Diamand2015-05-24
Add test case that git-p4 handles a setting of P4EDITOR that takes arguments, e.g. "gvim -f". This currently fails. Signed-off-by: Luke Diamand <luke@diamand.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>