aboutsummaryrefslogtreecommitdiff
path: root/url.c
Commit message (Collapse)AuthorAge
* Do not unquote + into ' ' in URLsThomas Rast2010-07-25
| | | | | | | | | | | | | | | | | Since 9d2e942 (decode file:// and ssh:// URLs, 2010-05-23) the URL logic unquotes escaped URLs. For the %2B type of escape, this is conformant with RFC 2396. However, it also unquotes + into a space character, which is only appropriate for the query strings in HTTP. This notably broke fetching from the gtk+ repository. We cannot just remove the corresponding code since the same url_decode_internal() is also used by the HTTP backend to decode query parameters. Introduce a new argument that controls whether the + decoding happens, and use it only in the (client-side) url_decode(). Reported-by: Jasper St. Pierre <jstpierre@mecheye.net> Signed-off-by: Thomas Rast <trast@student.ethz.ch> Signed-off-by: Junio C Hamano <gitster@pobox.com>
* url_decode: URL scheme ends with a colon and does not require a slashJunio C Hamano2010-06-24
| | | | Signed-off-by: Junio C Hamano <gitster@pobox.com>
* url.c: "<scheme>://" part at the beginning should not be URL decodedJunio C Hamano2010-06-23
| | | | | | | | | | | | When using the protocol git+ssh:// for example we do not want to decode the '+' as a space. The url decoding must take place only for the server name and parameters. This fixes a regression introduced in 9d2e942. Initial-fix-by: Pascal Obry <pascal.obry@gmail.com> Acked-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
* make url-related functions reusableJeff King2010-05-24
The is_url function and url percent-decoding functions were static, but are generally useful. Let's make them available to other parts of the code. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>