From eccb614924c9067eeceffa503e4da3683f1c8b6b Mon Sep 17 00:00:00 2001 From: Jeff King Date: Tue, 9 Jul 2013 20:19:12 -0400 Subject: use "sentinel" function attribute for variadic lists This attribute can help gcc notice when callers forget to add a NULL sentinel to the end of the function. This is our first use of the sentinel attribute, but we shouldn't need to #ifdef for other compilers, as __attribute__ is already a no-op on non-gcc-compatible compilers. Suggested-by: Bert Wesarg More-Spots-Found-By: Matt Kraai Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- argv-array.h | 1 + 1 file changed, 1 insertion(+) (limited to 'argv-array.h') diff --git a/argv-array.h b/argv-array.h index 40248d424..e8057483a 100644 --- a/argv-array.h +++ b/argv-array.h @@ -15,6 +15,7 @@ void argv_array_init(struct argv_array *); void argv_array_push(struct argv_array *, const char *); __attribute__((format (printf,2,3))) void argv_array_pushf(struct argv_array *, const char *fmt, ...); +__attribute__((sentinel)) void argv_array_pushl(struct argv_array *, ...); void argv_array_pop(struct argv_array *); void argv_array_clear(struct argv_array *); -- cgit v1.2.1