From 54307ea7c3ced760ee375483a786ec7180798aed Mon Sep 17 00:00:00 2001 From: Junio C Hamano Date: Fri, 8 Jul 2016 10:09:28 -0700 Subject: commit.c: remove print_commit_list() The helper function tries to offer a way to conveniently show the last one differently from others, presumably to allow you to say something like A, B, and C. while iterating over a list that has these three elements. However, there is only one caller, and it passes the same format string "%s\n" for both the last one and the other ones. Retire the helper function and update the caller with a simplified version. Signed-off-by: Junio C Hamano --- bisect.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'bisect.c') diff --git a/bisect.c b/bisect.c index dc13319c2..02f76f0f5 100644 --- a/bisect.c +++ b/bisect.c @@ -646,7 +646,10 @@ static void exit_if_skipped_commits(struct commit_list *tried, printf("There are only 'skip'ped commits left to test.\n" "The first %s commit could be any of:\n", term_bad); - print_commit_list(tried, "%s\n", "%s\n"); + + for ( ; tried; tried = tried->next) + printf("%s\n", oid_to_hex(&tried->item->object.oid)); + if (bad) printf("%s\n", oid_to_hex(bad)); printf("We cannot bisect more!\n"); -- cgit v1.2.1