From 9ef5e2a7223fbabf6a29946c1c120bc2c3c6cf86 Mon Sep 17 00:00:00 2001 From: Jacopo Notarstefano Date: Fri, 28 Feb 2014 12:09:04 +0100 Subject: branch.c: delete size check of newly tracked branch names Since commit 6f084a56 the length of a newly tracked branch name was limited to 1019 = 1024 - 7 - 7 - 1 characters, a bound derived by having to store this name in a char[1024] called key with two strings of length at most 7 and a '\0' character. This was no longer necessary as of commit a9f2c136, which uses a strbuf (documented in Documentation/technical/api-strbuf.txt) to store this value. Remove this unneeded check to allow branch names longer than 1019 characters. Signed-off-by: Jacopo Notarstefano Signed-off-by: Junio C Hamano --- branch.c | 4 ---- 1 file changed, 4 deletions(-) (limited to 'branch.c') diff --git a/branch.c b/branch.c index 2d15c19e3..19571b598 100644 --- a/branch.c +++ b/branch.c @@ -114,10 +114,6 @@ static int setup_tracking(const char *new_ref, const char *orig_ref, struct tracking tracking; int config_flags = quiet ? 0 : BRANCH_CONFIG_VERBOSE; - if (strlen(new_ref) > 1024 - 7 - 7 - 1) - return error(_("Tracking not set up: name too long: %s"), - new_ref); - memset(&tracking, 0, sizeof(tracking)); tracking.spec.dst = (char *)orig_ref; if (for_each_remote(find_tracked_branch, &tracking)) -- cgit v1.2.1