From 91c8d5905c33e9d7c9014a1c6c7cec8eb86584df Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Sun, 24 Jun 2007 21:20:41 +0200 Subject: detect close failure on just-written file handles I audited git for potential undetected write failures. In the cases fixed below, the diagnostics I add mimic the diagnostics used in surrounding code, even when that means not reporting the precise strerror(errno) cause of the error. Signed-off-by: Jim Meyering Signed-off-by: Junio C Hamano --- builtin-rerere.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'builtin-rerere.c') diff --git a/builtin-rerere.c b/builtin-rerere.c index f6409b93c..29fb075d2 100644 --- a/builtin-rerere.c +++ b/builtin-rerere.c @@ -57,7 +57,8 @@ static int write_rr(struct path_list *rr, int out_fd) write_in_full(out_fd, path, length) != length) die("unable to write rerere record"); } - close(out_fd); + if (close(out_fd) != 0) + die("unable to write rerere record"); return commit_lock_file(&write_lock); } -- cgit v1.2.1