From 28b3563241ac13733781fb0bada37f776a39f43d Mon Sep 17 00:00:00 2001 From: Jeff King Date: Thu, 24 Jul 2014 00:41:11 -0400 Subject: free ref string returned by dwim_ref A call to "dwim_ref(name, len, flags, &ref)" will allocate a new string in "ref" to return the exact ref we found. We do not consistently free it in all code paths, leading to small leaks. The worst is in get_sha1_basic, which may be called many times (e.g., by "cat-file --batch"), though it is relatively unlikely, as it only triggers on a bogus reflog specification. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- builtin/rev-parse.c | 1 + 1 file changed, 1 insertion(+) (limited to 'builtin/rev-parse.c') diff --git a/builtin/rev-parse.c b/builtin/rev-parse.c index 1a6122d3a..0bce2a63d 100644 --- a/builtin/rev-parse.c +++ b/builtin/rev-parse.c @@ -150,6 +150,7 @@ static void show_rev(int type, const unsigned char *sha1, const char *name) error("refname '%s' is ambiguous", name); break; } + free(full); } else { show_with_type(type, name); } -- cgit v1.2.1