From ffb20ce125f0ffe59002b1258b06c26747b69b7b Mon Sep 17 00:00:00 2001 From: Jeff King Date: Fri, 23 May 2014 16:03:47 -0400 Subject: strbuf: add strbuf_tolower function This is a convenience wrapper to call tolower on each character of the string. This makes config's lowercase() function obsolete, though note that because we have a strbuf, we are careful to operate over the whole strbuf, rather than assuming that a NUL is the end-of-string. We could continue to offer a pure-string lowercase, but there would be no callers (in most pure-string cases, we actually duplicate and lowercase the duplicate, for which we have the xstrdup_tolower wrapper). Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- config.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) (limited to 'config.c') diff --git a/config.c b/config.c index a30cb5c07..03ce5c684 100644 --- a/config.c +++ b/config.c @@ -147,12 +147,6 @@ int git_config_include(const char *var, const char *value, void *data) return ret; } -static void lowercase(char *p) -{ - for (; *p; p++) - *p = tolower(*p); -} - void git_config_push_parameter(const char *text) { struct strbuf env = STRBUF_INIT; @@ -180,7 +174,7 @@ int git_config_parse_parameter(const char *text, strbuf_list_free(pair); return error("bogus config parameter: %s", text); } - lowercase(pair[0]->buf); + strbuf_tolower(pair[0]); if (fn(pair[0]->buf, pair[1] ? pair[1]->buf : NULL, data) < 0) { strbuf_list_free(pair); return -1; -- cgit v1.2.1