From 39b2f6af6e009c2c087eeec293e98222eb396263 Mon Sep 17 00:00:00 2001 From: Jeff King Date: Wed, 6 Sep 2017 08:30:28 -0400 Subject: system_path: move RUNTIME_PREFIX to a sub-function The system_path() function has an #ifdef in the middle of it. Let's move the conditional logic into a sub-function. This isolates it more, which will make it easier to change and add to. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- exec_cmd.c | 33 +++++++++++++++++++++------------ 1 file changed, 21 insertions(+), 12 deletions(-) (limited to 'exec_cmd.c') diff --git a/exec_cmd.c b/exec_cmd.c index fb94aeba9..61092e971 100644 --- a/exec_cmd.c +++ b/exec_cmd.c @@ -7,19 +7,12 @@ static const char *argv_exec_path; static const char *argv0_path; -char *system_path(const char *path) -{ #ifdef RUNTIME_PREFIX - static const char *prefix; -#else - static const char *prefix = PREFIX; -#endif - struct strbuf d = STRBUF_INIT; - if (is_absolute_path(path)) - return xstrdup(path); +static const char *system_prefix(void) +{ + static const char *prefix; -#ifdef RUNTIME_PREFIX assert(argv0_path); assert(is_absolute_path(argv0_path)); @@ -32,9 +25,25 @@ char *system_path(const char *path) "but prefix computation failed. " "Using static fallback '%s'.\n", prefix); } -#endif + return prefix; +} +#else + +static const char *system_prefix(void) +{ + return PREFIX; +} + +#endif /* RUNTIME_PREFIX */ + +char *system_path(const char *path) +{ + struct strbuf d = STRBUF_INIT; + + if (is_absolute_path(path)) + return xstrdup(path); - strbuf_addf(&d, "%s/%s", prefix, path); + strbuf_addf(&d, "%s/%s", system_prefix(), path); return strbuf_detach(&d, NULL); } -- cgit v1.2.1