From ad2c928001d2d94f2cbf3c75734061eb8fc4383c Mon Sep 17 00:00:00 2001 From: "Stefan-W. Hahn" Date: Sat, 27 Feb 2010 15:20:26 +0100 Subject: git-am: Add command line parameter `--keep-cr` passing it to git-mailsplit c2ca1d7 (Allow mailsplit (and hence git-am) to handle mails with CRLF line-endings, 2009-08-04) fixed "git mailsplit" to help people with MUA whose output from save-as command uses CRLF as line terminators by stripping CR at the end of lines. However, when you know you are feeding output from "git format-patch" directly to "git am", and especially when your contents have CR at the end of line, such stripping is undesirable. To help such a use case, teach --keep-cr option to "git am" and pass that to "git mailinfo". Signed-off-by: Stefan-W. Hahn Signed-off-by: Junio C Hamano --- git-am.sh | 22 +++++++++++++++------- 1 file changed, 15 insertions(+), 7 deletions(-) (limited to 'git-am.sh') diff --git a/git-am.sh b/git-am.sh index ebfbee59d..dc8d242be 100755 --- a/git-am.sh +++ b/git-am.sh @@ -15,6 +15,7 @@ q,quiet be quiet s,signoff add a Signed-off-by line to the commit message u,utf8 recode into utf8 (default) k,keep pass -k flag to git-mailinfo +keep-cr pass --keep-cr flag to git-mailsplit for mbox format c,scissors strip everything before a scissors line whitespace= pass it through git-apply ignore-space-change pass it through git-apply @@ -217,12 +218,12 @@ check_patch_format () { split_patches () { case "$patch_format" in mbox) - case "$rebasing" in - '') - keep_cr= ;; - ?*) - keep_cr=--keep-cr ;; - esac + if test -n "$rebasing$keepcr" + then + keep_cr=--keep-cr + else + keep_cr= + fi git mailsplit -d"$prec" -o"$dotest" -b $keep_cr -- "$@" > "$dotest/last" || clean_abort ;; @@ -291,7 +292,7 @@ split_patches () { prec=4 dotest="$GIT_DIR/rebase-apply" -sign= utf8=t keep= skip= interactive= resolved= rebasing= abort= +sign= utf8=t keep= keepcr= skip= interactive= resolved= rebasing= abort= resolvemsg= resume= scissors= no_inbody_headers= git_apply_opt= committer_date_is_author_date= @@ -348,6 +349,8 @@ do allow_rerere_autoupdate="$1" ;; -q|--quiet) GIT_QUIET=t ;; + --keep-cr) + keepcr=t ;; --) shift; break ;; *) @@ -453,6 +456,7 @@ else echo "$sign" >"$dotest/sign" echo "$utf8" >"$dotest/utf8" echo "$keep" >"$dotest/keep" + echo "$keepcr" >"$dotest/keepcr" echo "$scissors" >"$dotest/scissors" echo "$no_inbody_headers" >"$dotest/no_inbody_headers" echo "$GIT_QUIET" >"$dotest/quiet" @@ -496,6 +500,10 @@ if test "$(cat "$dotest/keep")" = t then keep=-k fi +if test "$(cat "$dotest/keepcr")" = t +then + keepcr=--keep-cr +fi case "$(cat "$dotest/scissors")" in t) scissors=--scissors ;; -- cgit v1.2.1 From e80d4cbefce106506ec217f9ab279bcf0b84a2e9 Mon Sep 17 00:00:00 2001 From: "Stefan-W. Hahn" Date: Sat, 27 Feb 2010 15:20:27 +0100 Subject: git-am: Add am.keepcr and --no-keep-cr to override it This patch adds the configuration `am.keepcr` for git-am. It also adds `--no-keep-cr` parameter for git-am to give the possibility to override configuration from command line. Signed-off-by: Stefan-W. Hahn Signed-off-by: Junio C Hamano --- git-am.sh | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) (limited to 'git-am.sh') diff --git a/git-am.sh b/git-am.sh index dc8d242be..a2004506c 100755 --- a/git-am.sh +++ b/git-am.sh @@ -16,6 +16,7 @@ s,signoff add a Signed-off-by line to the commit message u,utf8 recode into utf8 (default) k,keep pass -k flag to git-mailinfo keep-cr pass --keep-cr flag to git-mailsplit for mbox format +no-keep-cr do not pass --keep-cr flag to git-mailsplit independent of am.keepcr c,scissors strip everything before a scissors line whitespace= pass it through git-apply ignore-space-change pass it through git-apply @@ -218,7 +219,7 @@ check_patch_format () { split_patches () { case "$patch_format" in mbox) - if test -n "$rebasing$keepcr" + if test -n "$rebasing" || test t = "$keepcr" then keep_cr=--keep-cr else @@ -299,6 +300,11 @@ committer_date_is_author_date= ignore_date= allow_rerere_autoupdate= +if test "$(git config --bool --get am.keepcr)" = true +then + keepcr=t +fi + while test $# != 0 do case "$1" in @@ -351,6 +357,8 @@ do GIT_QUIET=t ;; --keep-cr) keepcr=t ;; + --no-keep-cr) + keepcr=f ;; --) shift; break ;; *) @@ -500,10 +508,12 @@ if test "$(cat "$dotest/keep")" = t then keep=-k fi -if test "$(cat "$dotest/keepcr")" = t -then - keepcr=--keep-cr -fi +case "$(cat "$dotest/keepcr")" in +t) + keepcr=--keep-cr ;; +f) + keepcr=--no-keep-cr ;; +esac case "$(cat "$dotest/scissors")" in t) scissors=--scissors ;; -- cgit v1.2.1