From af14b5cf1bec831f90fb5d4136e0205de802b01b Mon Sep 17 00:00:00 2001 From: David Aguilar Date: Fri, 15 Feb 2013 21:47:43 -0800 Subject: difftool: silence uninitialized variable warning Git::config() returns `undef` when given keys that do not exist. Check that the $guitool value is defined to prevent a noisy "Use of uninitialized variable $guitool in length" warning. Signed-off-by: David Aguilar Signed-off-by: Junio C Hamano --- git-difftool.perl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'git-difftool.perl') diff --git a/git-difftool.perl b/git-difftool.perl index 0a90de414..12231fbc6 100755 --- a/git-difftool.perl +++ b/git-difftool.perl @@ -336,7 +336,7 @@ sub main } if ($opts{gui}) { my $guitool = Git::config('diff.guitool'); - if (length($guitool) > 0) { + if (defined($guitool) && length($guitool) > 0) { $ENV{GIT_DIFF_TOOL} = $guitool; } } -- cgit v1.2.1