From 974b50c5565107e1e3209176682ee6f6e420bd2b Mon Sep 17 00:00:00 2001 From: Ben Peart Date: Fri, 5 May 2017 11:27:54 -0400 Subject: pkt-line: fix packet_read_line() to handle len < 0 errors Update packet_read_line() to test for len > 0 to avoid potential bug if read functions return lengths less than zero to indicate errors. Signed-off-by: Ben Peart Found/Fixed-by: Lars Schneider Signed-off-by: Junio C Hamano --- pkt-line.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'pkt-line.c') diff --git a/pkt-line.c b/pkt-line.c index d4b6bfe07..6f05b1a4a 100644 --- a/pkt-line.c +++ b/pkt-line.c @@ -315,7 +315,7 @@ static char *packet_read_line_generic(int fd, PACKET_READ_CHOMP_NEWLINE); if (dst_len) *dst_len = len; - return len ? packet_buffer : NULL; + return (len > 0) ? packet_buffer : NULL; } char *packet_read_line(int fd, int *len_p) -- cgit v1.2.1