From 81c3ce3cdce8dffb913243f5b2cc09d9fb966e6c Mon Sep 17 00:00:00 2001 From: Stefan Beller Date: Sun, 10 Aug 2014 23:33:26 +0200 Subject: prepare_revision_walk(): check for return value in all places Even the documentation tells us: You should check if it returns any error (non-zero return code) and if it does not, you can start using get_revision() to do the iteration. In preparation for this commit, I grepped all occurrences of prepare_revision_walk and added error messages, when there were none. Signed-off-by: Stefan Beller Signed-off-by: Junio C Hamano --- remote.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'remote.c') diff --git a/remote.c b/remote.c index 0e9459cc0..dc0c42796 100644 --- a/remote.c +++ b/remote.c @@ -1898,7 +1898,8 @@ int stat_tracking_info(struct branch *branch, int *num_ours, int *num_theirs) init_revisions(&revs, NULL); setup_revisions(rev_argc, rev_argv, &revs, NULL); - prepare_revision_walk(&revs); + if (prepare_revision_walk(&revs)) + die("revision walk setup failed"); /* ... and count the commits on each side. */ *num_ours = 0; -- cgit v1.2.1