From 825cee7b285d9c733e9aec03cf4362e8029ee1c1 Mon Sep 17 00:00:00 2001 From: Andy Whitcroft Date: Tue, 2 Jan 2007 14:12:09 +0000 Subject: send pack check for failure to send revisions list When passing the revisions list to pack-objects we do not check for errors nor short writes. Introduce a new write_in_full which will handle short writes and report errors to the caller. Use this to short cut the send on failure, allowing us to wait for and report the child in case the failure is its fault. Signed-off-by: Andy Whitcroft Signed-off-by: Junio C Hamano --- send-pack.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) (limited to 'send-pack.c') diff --git a/send-pack.c b/send-pack.c index eaa6efbc0..c195d080d 100644 --- a/send-pack.c +++ b/send-pack.c @@ -65,12 +65,16 @@ static int pack_objects(int fd, struct ref *refs) memcpy(buf + 1, sha1_to_hex(refs->old_sha1), 40); buf[0] = '^'; buf[41] = '\n'; - write(pipe_fd[1], buf, 42); + if (!write_in_full(pipe_fd[1], buf, 42, + "send-pack: send refs")) + break; } if (!is_null_sha1(refs->new_sha1)) { memcpy(buf, sha1_to_hex(refs->new_sha1), 40); buf[40] = '\n'; - write(pipe_fd[1], buf, 41); + if (!write_in_full(pipe_fd[1], buf, 41, + "send-pack: send refs")) + break; } refs = refs->next; } -- cgit v1.2.1