From c697ad143ba1ff58b29e7efe149d244d4b7010a5 Mon Sep 17 00:00:00 2001 From: Heikki Orsila Date: Sat, 3 May 2008 16:27:26 +0300 Subject: Cleanup xread() loops to use read_in_full() Signed-off-by: Heikki Orsila Signed-off-by: Junio C Hamano --- sha1_file.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) (limited to 'sha1_file.c') diff --git a/sha1_file.c b/sha1_file.c index c2ab7ea11..3516777bc 100644 --- a/sha1_file.c +++ b/sha1_file.c @@ -2466,16 +2466,10 @@ int index_path(unsigned char *sha1, const char *path, struct stat *st, int write int read_pack_header(int fd, struct pack_header *header) { - char *c = (char*)header; - ssize_t remaining = sizeof(struct pack_header); - do { - ssize_t r = xread(fd, c, remaining); - if (r <= 0) - /* "eof before pack header was fully read" */ - return PH_ERROR_EOF; - remaining -= r; - c += r; - } while (remaining > 0); + if (read_in_full(fd, header, sizeof(*header)) < sizeof(*header)) + /* "eof before pack header was fully read" */ + return PH_ERROR_EOF; + if (header->hdr_signature != htonl(PACK_SIGNATURE)) /* "protocol error (pack signature mismatch detected)" */ return PH_ERROR_PACK_SIGNATURE; -- cgit v1.2.1