From 6c8afe495b2cb6e2069942d7c006f6660e186690 Mon Sep 17 00:00:00 2001 From: Michael Haggerty Date: Fri, 3 Jul 2015 15:59:32 +0200 Subject: strbuf: strbuf_read_file() should return ssize_t It is currently declared to return int, which could overflow for large files. Signed-off-by: Michael Haggerty Signed-off-by: Junio C Hamano --- strbuf.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'strbuf.c') diff --git a/strbuf.c b/strbuf.c index 88cafd4a7..b4da9f5d0 100644 --- a/strbuf.c +++ b/strbuf.c @@ -481,9 +481,10 @@ int strbuf_getwholeline_fd(struct strbuf *sb, int fd, int term) return 0; } -int strbuf_read_file(struct strbuf *sb, const char *path, size_t hint) +ssize_t strbuf_read_file(struct strbuf *sb, const char *path, size_t hint) { - int fd, len; + int fd; + ssize_t len; fd = open(path, O_RDONLY); if (fd < 0) -- cgit v1.2.1