From 6c8afe495b2cb6e2069942d7c006f6660e186690 Mon Sep 17 00:00:00 2001 From: Michael Haggerty Date: Fri, 3 Jul 2015 15:59:32 +0200 Subject: strbuf: strbuf_read_file() should return ssize_t It is currently declared to return int, which could overflow for large files. Signed-off-by: Michael Haggerty Signed-off-by: Junio C Hamano --- strbuf.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'strbuf.h') diff --git a/strbuf.h b/strbuf.h index 1883494ca..1ea9d0bde 100644 --- a/strbuf.h +++ b/strbuf.h @@ -364,7 +364,7 @@ extern ssize_t strbuf_read(struct strbuf *, int fd, size_t hint); * Read the contents of a file, specified by its path. The third argument * can be used to give a hint about the file size, to avoid reallocs. */ -extern int strbuf_read_file(struct strbuf *sb, const char *path, size_t hint); +extern ssize_t strbuf_read_file(struct strbuf *sb, const char *path, size_t hint); /** * Read the target of a symbolic link, specified by its path. The third -- cgit v1.2.1