From 4621085b7eb2f4cffe16d508988ff9b4a874b4ef Mon Sep 17 00:00:00 2001 From: Jeff King Date: Tue, 9 Jul 2013 20:18:40 -0400 Subject: add missing "format" function attributes For most of our functions that take printf-like formats, we use gcc's __attribute__((format)) to get compiler warnings when the functions are misused. Let's give a few more functions the same protection. In most cases, the annotations do not uncover any actual bugs; the only code change needed is that we passed a size_t to transfer_debug, which expected an int. Since we expect the passed-in value to be a relatively small buffer size (and cast a similar value to int directly below), we can just cast away the problem. Signed-off-by: Jeff King Signed-off-by: Junio C Hamano --- utf8.h | 1 + 1 file changed, 1 insertion(+) (limited to 'utf8.h') diff --git a/utf8.h b/utf8.h index 32a7bfb98..65d0e42b9 100644 --- a/utf8.h +++ b/utf8.h @@ -10,6 +10,7 @@ int utf8_strwidth(const char *string); int is_utf8(const char *text); int is_encoding_utf8(const char *name); int same_encoding(const char *, const char *); +__attribute__((format (printf, 2, 3))) int utf8_fprintf(FILE *, const char *, ...); void strbuf_add_wrapped_text(struct strbuf *buf, -- cgit v1.2.1