diff options
| author | Junio C Hamano <gitster@pobox.com> | 2016-10-28 09:01:16 -0700 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2016-10-28 09:01:16 -0700 |
| commit | a5406125cc3989a7007d4fad7e5757cdb9837ebf (patch) | |
| tree | bbd443e667513d2f72ca573e29d8df74acfd905d | |
| parent | a42539f7de3f2516437fe4ee2d3bf769a27c89ab (diff) | |
| parent | 171c646f8c6484cca76933ebe8a6af52df47277d (diff) | |
| download | git-a5406125cc3989a7007d4fad7e5757cdb9837ebf.tar.gz git-a5406125cc3989a7007d4fad7e5757cdb9837ebf.tar.xz | |
Merge branch 'dk/worktree-dup-checkout-with-bare-is-ok' into maint
In a worktree connected to a repository elsewhere, created via "git
worktree", "git checkout" attempts to protect users from confusion
by refusing to check out a branch that is already checked out in
another worktree. However, this also prevented checking out a
branch, which is designated as the primary branch of a bare
reopsitory, in a worktree that is connected to the bare
repository. The check has been corrected to allow it.
* dk/worktree-dup-checkout-with-bare-is-ok:
worktree: allow the main brach of a bare repository to be checked out
| -rwxr-xr-x | t/t2025-worktree-add.sh | 8 | ||||
| -rw-r--r-- | worktree.c | 2 |
2 files changed, 10 insertions, 0 deletions
diff --git a/t/t2025-worktree-add.sh b/t/t2025-worktree-add.sh index 4bcc335a1..b618d6be2 100755 --- a/t/t2025-worktree-add.sh +++ b/t/t2025-worktree-add.sh @@ -138,6 +138,14 @@ test_expect_success 'checkout from a bare repo without "add"' ' ) ' +test_expect_success '"add" default branch of a bare repo' ' + ( + git clone --bare . bare2 && + cd bare2 && + git worktree add ../there3 master + ) +' + test_expect_success 'checkout with grafts' ' test_when_finished rm .git/info/grafts && test_commit abc && diff --git a/worktree.c b/worktree.c index 5acfe4cd6..f7869f8d6 100644 --- a/worktree.c +++ b/worktree.c @@ -345,6 +345,8 @@ const struct worktree *find_shared_symref(const char *symref, for (i = 0; worktrees[i]; i++) { struct worktree *wt = worktrees[i]; + if (wt->is_bare) + continue; if (wt->is_detached && !strcmp(symref, "HEAD")) { if (is_worktree_being_rebased(wt, target)) { |