diff options
| author | Brandon Casey <drafnel@gmail.com> | 2009-07-16 16:25:19 -0500 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2009-07-16 15:09:21 -0700 |
| commit | b45a09c4b4a80ccc6eeb0f390ab8f4eb6f31c922 (patch) | |
| tree | 68ddec4a335c467bc84624b018e71259d4e5ff24 | |
| parent | 9d33f7c22fda81f7be8a7aa1576e6d399d3b45ec (diff) | |
| download | git-b45a09c4b4a80ccc6eeb0f390ab8f4eb6f31c922.tar.gz git-b45a09c4b4a80ccc6eeb0f390ab8f4eb6f31c922.tar.xz | |
sha1_name.c: avoid unnecessary strbuf_release
When we fall back to a standard for_each_reflog_ent() after failing to find
the nth branch switch (or if we had a short reflog) with the call to
for_each_recent_reflog_ent(), we do not need to free the memory allocated
for our strbuf's since a strbuf_reset() will be performed in
grab_nth_branch_switch() before assigning to the entry.
Plus, the strbuf_release() negates the non-zero hint we initially gave to
strbuf_init() just above these lines.
Signed-off-by: Brandon Casey <drafnel@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | sha1_name.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/sha1_name.c b/sha1_name.c index 904bcd96a..44bb62d27 100644 --- a/sha1_name.c +++ b/sha1_name.c @@ -777,8 +777,6 @@ int interpret_branch_name(const char *name, struct strbuf *buf) for_each_recent_reflog_ent("HEAD", grab_nth_branch_switch, 40960, &cb); if (cb.cnt < nth) { cb.cnt = 0; - for (i = 0; i < nth; i++) - strbuf_release(&cb.buf[i]); for_each_reflog_ent("HEAD", grab_nth_branch_switch, &cb); } if (cb.cnt < nth) |