diff options
| author | Elia Pinto <gitter.spiros@gmail.com> | 2015-12-22 15:10:24 +0100 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2015-12-27 15:33:13 -0800 |
| commit | cc301d7e5193801208588cbd54cf1af91b6f7a00 (patch) | |
| tree | 5fc0d64ffe69f584141f70e1a642232115a7d6a5 | |
| parent | a22c9e8d9e29277f51b77aff8d0eee3945577e72 (diff) | |
| download | git-cc301d7e5193801208588cbd54cf1af91b6f7a00.tar.gz git-cc301d7e5193801208588cbd54cf1af91b6f7a00.tar.xz | |
contrib/examples/git-fetch.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command
substitution instead of using the backquotes `...`.
The backquoted form is the traditional method for command
substitution, and is supported by POSIX. However, all but the
simplest uses become complicated quickly. In particular, embedded
command substitutions and/or the use of double quotes require
careful escaping with the backslash character.
The patch was generated by:
for _f in $(find . -name "*.sh")
do
perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}"
done
and then carefully proof-read.
Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rwxr-xr-x | contrib/examples/git-fetch.sh | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/contrib/examples/git-fetch.sh b/contrib/examples/git-fetch.sh index 554070909..57d2e5616 100755 --- a/contrib/examples/git-fetch.sh +++ b/contrib/examples/git-fetch.sh @@ -146,13 +146,13 @@ esac reflist=$(get_remote_refs_for_fetch "$@") if test "$tags" then - taglist=`IFS=' ' && + taglist=$(IFS=' ' && echo "$ls_remote_result" | git show-ref --exclude-existing=refs/tags/ | while read sha1 name do echo ".${name}:${name}" - done` || exit + done) || exit if test "$#" -gt 1 then # remote URL plus explicit refspecs; we need to merge them. |