diff options
| author | Elia Pinto <gitter.spiros@gmail.com> | 2014-06-06 07:55:48 -0700 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2014-06-09 14:47:06 -0700 |
| commit | cd4de93f2e34ded30bd6b7a7352b45650ad81a83 (patch) | |
| tree | 59134663c0ebfda64f76e08980820a580a7efaf5 | |
| parent | 57b74cdaba2aaaee7d29838a7e6f3ed5581b1992 (diff) | |
| download | git-cd4de93f2e34ded30bd6b7a7352b45650ad81a83.tar.gz git-cd4de93f2e34ded30bd6b7a7352b45650ad81a83.tar.xz | |
contrib/examples/git-repack.sh: avoid "test <cond> -a/-o <cond>"
The construct is error-prone; "test" being built-in in most modern
shells, the reason to avoid "test <cond> && test <cond>" spawning
one extra process by using a single "test <cond> -a <cond>" no
longer exists.
Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rwxr-xr-x | contrib/examples/git-repack.sh | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/contrib/examples/git-repack.sh b/contrib/examples/git-repack.sh index f312405a2..96e3fed32 100755 --- a/contrib/examples/git-repack.sh +++ b/contrib/examples/git-repack.sh @@ -76,8 +76,8 @@ case ",$all_into_one," in existing="$existing $e" fi done - if test -n "$existing" -a -n "$unpack_unreachable" -a \ - -n "$remove_redundant" + if test -n "$existing" && test -n "$unpack_unreachable" && \ + test -n "$remove_redundant" then # This may have arbitrary user arguments, so we # have to protect it against whitespace splitting |