diff options
| author | Junio C Hamano <junkio@cox.net> | 2006-12-19 14:34:12 -0800 |
|---|---|---|
| committer | Junio C Hamano <junkio@cox.net> | 2006-12-20 09:51:35 -0800 |
| commit | 85023577a8f4b540aa64aa37f6f44578c0c305a3 (patch) | |
| tree | 52bd684220373101748992325bdbe67e5aa573c6 /compat | |
| parent | 6d2fa7f1b489c65e677c18eda5c144dbc5d614ab (diff) | |
| download | git-85023577a8f4b540aa64aa37f6f44578c0c305a3.tar.gz git-85023577a8f4b540aa64aa37f6f44578c0c305a3.tar.xz | |
simplify inclusion of system header files.
This is a mechanical clean-up of the way *.c files include
system header files.
(1) sources under compat/, platform sha-1 implementations, and
xdelta code are exempt from the following rules;
(2) the first #include must be "git-compat-util.h" or one of
our own header file that includes it first (e.g. config.h,
builtin.h, pkt-line.h);
(3) system headers that are included in "git-compat-util.h"
need not be included in individual C source files.
(4) "git-compat-util.h" does not have to include subsystem
specific header files (e.g. expat.h).
Signed-off-by: Junio C Hamano <junkio@cox.net>
Diffstat (limited to 'compat')
| -rw-r--r-- | compat/mmap.c | 4 | ||||
| -rw-r--r-- | compat/setenv.c | 3 | ||||
| -rw-r--r-- | compat/strlcpy.c | 2 | ||||
| -rw-r--r-- | compat/unsetenv.c | 3 |
4 files changed, 3 insertions, 9 deletions
diff --git a/compat/mmap.c b/compat/mmap.c index a4d2e507f..0fd46e793 100644 --- a/compat/mmap.c +++ b/compat/mmap.c @@ -1,7 +1,3 @@ -#include <stdio.h> -#include <stdlib.h> -#include <unistd.h> -#include <errno.h> #include "../git-compat-util.h" void *gitfakemmap(void *start, size_t length, int prot , int flags, int fd, off_t offset) diff --git a/compat/setenv.c b/compat/setenv.c index b7d767859..3a22ea7b7 100644 --- a/compat/setenv.c +++ b/compat/setenv.c @@ -1,5 +1,4 @@ -#include <stdlib.h> -#include <string.h> +#include "../git-compat-util.h" int gitsetenv(const char *name, const char *value, int replace) { diff --git a/compat/strlcpy.c b/compat/strlcpy.c index b66856a3a..4024c3603 100644 --- a/compat/strlcpy.c +++ b/compat/strlcpy.c @@ -1,4 +1,4 @@ -#include <string.h> +#include "../git-compat-util.h" size_t gitstrlcpy(char *dest, const char *src, size_t size) { diff --git a/compat/unsetenv.c b/compat/unsetenv.c index 3a5e4ec04..eb29f5e08 100644 --- a/compat/unsetenv.c +++ b/compat/unsetenv.c @@ -1,5 +1,4 @@ -#include <stdlib.h> -#include <string.h> +#include "../git-compat-util.h" void gitunsetenv (const char *name) { |