aboutsummaryrefslogtreecommitdiff
path: root/git-gui/lib/option.tcl
diff options
context:
space:
mode:
authorMartin Ågren <martin.agren@gmail.com>2017-08-21 19:43:45 +0200
committerJunio C Hamano <gitster@pobox.com>2017-08-23 10:14:19 -0700
commit5c94c93d504e29c2099200a68926a34072cf2736 (patch)
tree807f1b5c339b70f85d80a8f896e8670194a6a82f /git-gui/lib/option.tcl
parent4d7268b888d7bb6d675340ec676e4239739d0f6d (diff)
downloadgit-5c94c93d504e29c2099200a68926a34072cf2736.tar.gz
git-5c94c93d504e29c2099200a68926a34072cf2736.tar.xz
convert: always initialize attr_action in convert_attrs
convert_attrs contains an "if-else". In the "if", we set attr_action twice, and the first assignment has no effect. In the "else", we do not set it at all. Since git_check_attr always returns the same value, we'll always end up in the "if", so there is no problem right now. But convert_attrs is obviously trying not to rely on such an implementation-detail of another component. Make the initialization of attr_action after the if-else. Remove the earlier assignments. Suggested-by: Torsten Bögershausen <tboegi@web.de> Signed-off-by: Martin Ågren <martin.agren@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'git-gui/lib/option.tcl')
0 files changed, 0 insertions, 0 deletions