aboutsummaryrefslogtreecommitdiff
path: root/git-quiltimport.sh
diff options
context:
space:
mode:
authorJosh Triplett <josh@freedesktop.org>2007-07-14 01:05:43 -0700
committerJunio C Hamano <gitster@pobox.com>2007-07-14 01:07:44 -0700
commit9d6f220cc8ffbd71b4c68765b52c3a7c41dd729b (patch)
tree618f04c4e0ebf509fc817a1e5c767c7f1d38ea9b /git-quiltimport.sh
parentbdecd9d41b3528e17aea2290344c584412e2424e (diff)
downloadgit-9d6f220cc8ffbd71b4c68765b52c3a7c41dd729b.tar.gz
git-9d6f220cc8ffbd71b4c68765b52c3a7c41dd729b.tar.xz
Remove useless uses of cat, and replace with filename arguments
Replace uses of cat that do nothing but writing the contents of a single file to another command via pipe. [jc: Original patch from Josh was somewhat buggy and rewrote "cat $file | wc -l" to "wc -l $file", but this one should be Ok.] Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'git-quiltimport.sh')
-rwxr-xr-xgit-quiltimport.sh7
1 files changed, 4 insertions, 3 deletions
diff --git a/git-quiltimport.sh b/git-quiltimport.sh
index 2124df9e4..9de54d19f 100755
--- a/git-quiltimport.sh
+++ b/git-quiltimport.sh
@@ -70,10 +70,11 @@ tmp_info="$tmp_dir/info"
commit=$(git rev-parse HEAD)
mkdir $tmp_dir || exit 2
-for patch_name in $(cat "$QUILT_PATCHES/series" | grep -v '^#'); do
+for patch_name in $(grep -v '^#' < "$QUILT_PATCHES/series" ); do
echo $patch_name
- (cat $QUILT_PATCHES/$patch_name | git mailinfo "$tmp_msg" "$tmp_patch" > "$tmp_info") || exit 3
- test -s .dotest/patch || {
+ git mailinfo "$tmp_msg" "$tmp_patch" \
+ <"$QUILT_PATCHES/$patch_name" >"$tmp_info" || exit 3
+ test -s "$tmp_patch" || {
echo "Patch is empty. Was it split wrong?"
exit 1
}